Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SNAP): change TransactionStateManager to support the search of multiple transaction calls #347

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Sep 5, 2024

This PR is to having multi calls search support in TransactionStateManager , hence to fit to the response from StarkScanClient

it includes:

  • timestamp is no longer needed multiply 1000
  • multi calls will move to new attribute "accountCalls" of Transaction Object

Requirement:

Requires this PR to be merged first:

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner September 5, 2024 05:25
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and jonesho and removed request for a team September 5, 2024 05:25
@stanleyyconsensys stanleyyconsensys changed the title refactor: change tx state manager to support multiple tx calls refactor: change TransactionStateManager to support the search of multiple transaction calls Sep 5, 2024
@stanleyyconsensys stanleyyconsensys mentioned this pull request Sep 6, 2024
1 task
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stanleyyconsensys stanleyyconsensys changed the title refactor: change TransactionStateManager to support the search of multiple transaction calls refactor(SNAP): change TransactionStateManager to support the search of multiple transaction calls Oct 22, 2024
@stanleyyconsensys stanleyyconsensys marked this pull request as draft October 22, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant